Add the provider for the Tencent Cloud. #2630

Hyzhou · 2022-03-04T09:55:51Z

Signed-off-by: misakazhou misakazhou@tencent.com

Description

Add the provider for tencent cloud.
PrivateDNS service provides intranet DNS resolution.
DNSPod service provides internet DNS resolution.
Unit tests and document is updated for the tencent cloud provider.

Any issue about the tencent cloud provider can ask @Hyzhou for help and upgrade.

Fixes #ISSUE

Checklist

Unit tests updated
End user documentation updated

k8s-ci-robot · 2022-03-04T09:55:59Z

Welcome @Hyzhou!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hyzhou · 2022-03-08T02:28:37Z

@Raffo Would you like to review this PR. Thank you.

k8s-triage-robot · 2022-06-19T18:09:20Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-07-19T18:34:21Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

lostz · 2022-08-05T06:45:23Z

I need it so much。

Hyzhou · 2022-08-05T07:52:50Z

I need it so much。

you can use it now.
https://cloud.tencent.com/document/product/457/72679

lostz · 2022-08-06T14:48:29Z

I need it so much。

you can use it now. https://cloud.tencent.com/document/product/457/72679

thx

ysicing · 2022-08-24T07:17:33Z

@Hyzhou only support Tencent Cloud(TKE)?

Hyzhou · 2022-08-24T07:53:30Z

@Hyzhou only support Tencent Cloud(TKE)?

It is a driver support for Tencent Cloud, and test in TKE Clusters.
But if you build an kubernetes cluster in Tencent Cloud by your self. I think this driver also work too.

ysicing · 2022-08-24T09:43:15Z

@Hyzhou example, I want to support DNSPod in EKS(Other Cloud K8s) Clusters, this driver maybe not work.

Hyzhou · 2022-08-25T03:18:51Z

/sig cloud-provider

Hyzhou · 2022-08-25T03:20:23Z

@Raffo @njuettner @seanmalloy Would you like to review this PR. Thank you.

ysicing · 2022-09-08T01:45:38Z

/assign @szuecs

szuecs · 2022-09-08T07:17:28Z

provider/tencentcloud/dnspod.go

+		}
+		for _, record := range records {
+			if *record.Type == "TXT" && strings.HasPrefix(*record.Value, "heritage=") {
+				record.Value = common.StringPtr(fmt.Sprintf("\"%s\"", *record.Value))


a bit nicer would be:

record.Value = common.StringPtr(fmt.Sprintf(`"%s"`, *record.Value))

szuecs · 2022-09-08T07:19:58Z

provider/tencentcloud/dnspod.go

+		for _, endpoint := range endpoints {
+			for _, target := range endpoint.Targets {
+				if endpoint.RecordType == "TXT" && strings.HasPrefix(target, "\"heritage=") {
+					target = strings.Trim(target, "\"")


I am just scrolling the code a bit and this line and the above looks a bit weird to me

szuecs · 2022-09-08T07:24:08Z

provider/tencentcloud/dnspod.go

+		for _, record := range recordGroup.RecordList {
+			key := *record.Type + ":" + *record.Name + "." + *recordGroup.Domain.Name
+			if *record.Name == TencentCloudEmptyPrefix {
+				key = *record.Type + ":" + *recordGroup.Domain.Name


I think you don't need to dereference pointers here (ibmcloud seems to also does it, but all others not) and basically all over the place. See also the inmemory provider.

Sorry, I just not understand only this feedback. I wants to group the target by dnsname and type here.

Ok sorry!
You can use for example record.Name without prepending *.
It's different from C or C++

key := record.Type + ":" + record.Name + "." + recordGroup.Domain.Name

like this? it looks wrong.

Yes like that and in general I prefer fmt.Sprintf for string concatenation.

record.Type is *string type. remove the * make go language syntax error.

fmt is ok, I already change to fmt.Sprintf

szuecs · 2022-09-08T07:25:48Z

provider/tencentcloud/tencent_cloud.go

+func NewTencentCloudProvider(domainFilter endpoint.DomainFilter, zoneIDFilter provider.ZoneIDFilter, configFile string, zoneType string, dryRun bool) (*TencentCloudProvider, error) {
+	cfg := tencentCloudConfig{}
+	if configFile != "" {
+		contents, err := ioutil.ReadFile(configFile)


os.ReadFile.

szuecs · 2022-09-08T07:26:23Z

provider/tencentcloud/tencent_cloud.go

+	if configFile != "" {
+		contents, err := ioutil.ReadFile(configFile)
+		if err != nil {
+			return nil, fmt.Errorf("failed to read Tencent Cloud config file '%s': %v", configFile, err)


Please use always:

fmt.Errorf("....: %w", err)

instead of %v

thank you, the above all points. I will check it soon.

szuecs · 2022-09-08T07:37:02Z

provider/tencentcloud/tencent_cloud_test.go

+			t.Errorf("Incorrect number of records: %d", len(endpoints))
+		}
+		for _, endpoint := range endpoints {
+			t.Logf("Endpoint for %++v", *endpoint)


%++v -> %+v

szuecs

Small Go code things here and there that requires fixes.
Other than that we have to discuss in maintainers meeting if we merge all provider PRs or if we have it on hold as we have since more than a half year.

szuecs · 2022-09-08T07:41:40Z

/remove-lifecycle rotten

szuecs · 2022-09-08T07:42:29Z

/assign @Raffo

szuecs · 2022-09-08T07:42:56Z

@Raffo to run the tests looks fine to me

Raffo · 2022-09-15T08:09:47Z

I approved tests to run, deferring to @szuecs for the final review and call on merge.

Raffo · 2022-09-15T08:17:53Z

I see this in the CI build:

sh -s -- -b $(go env GOPATH)/bin v1.45.2
golangci/golangci-lint info checking GitHub for tag 'v1.4[5](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:6).2'
golangci/golangci-lint info found version: 1.45.2 for v1.45.2/linux/amd[6](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:7)4
golangci/golangci-lint info installed /home/runner/go/bin/golangci-lint
>> checking license header
license header checking failed:
./provider/tencentcloud/privatedns.go
./provider/tencentcloud/dnspod.go
./provider/tencentcloud/tencent_cloud_test.go
make: *** [Makefile:5[8](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:9): licensecheck] Error 1
./provider/tencentcloud/cloudapi/readonlyapi.go
./provider/tencentcloud/cloudapi/mockapi.go
./provider/tencentcloud/cloudapi/clientset.go
./provider/tencentcloud/cloudapi/api.go
./provider/tencentcloud/cloudapi/tencentapi.go
./provider/tencentcloud/tencent_cloud.go
Error: Process completed with exit code 2.

there's also a conflict with the go.mod now. Can you please fix that @Hyzhou ?

Hyzhou · 2022-09-15T08:18:19Z

I see this in the CI build:

sh -s -- -b $(go env GOPATH)/bin v1.45.2
golangci/golangci-lint info checking GitHub for tag 'v1.4[5](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:6).2'
golangci/golangci-lint info found version: 1.45.2 for v1.45.2/linux/amd[6](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:7)4
golangci/golangci-lint info installed /home/runner/go/bin/golangci-lint
>> checking license header
license header checking failed:
./provider/tencentcloud/privatedns.go
./provider/tencentcloud/dnspod.go
./provider/tencentcloud/tencent_cloud_test.go
make: *** [Makefile:5[8](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:9): licensecheck] Error 1
./provider/tencentcloud/cloudapi/readonlyapi.go
./provider/tencentcloud/cloudapi/mockapi.go
./provider/tencentcloud/cloudapi/clientset.go
./provider/tencentcloud/cloudapi/api.go
./provider/tencentcloud/cloudapi/tencentapi.go
./provider/tencentcloud/tencent_cloud.go
Error: Process completed with exit code 2.

there's also a conflict with the go.mod now. Can you please fix that @Hyzhou ?

I get it

Hyzhou · 2022-09-15T08:24:54Z

I see this in the CI build:

sh -s -- -b $(go env GOPATH)/bin v1.45.2
golangci/golangci-lint info checking GitHub for tag 'v1.4[5](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:6).2'
golangci/golangci-lint info found version: 1.45.2 for v1.45.2/linux/amd[6](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:7)4
golangci/golangci-lint info installed /home/runner/go/bin/golangci-lint
>> checking license header
license header checking failed:
./provider/tencentcloud/privatedns.go
./provider/tencentcloud/dnspod.go
./provider/tencentcloud/tencent_cloud_test.go
make: *** [Makefile:5[8](https://github.com/kubernetes-sigs/external-dns/actions/runs/3031914931/jobs/4935438158#step:6:9): licensecheck] Error 1
./provider/tencentcloud/cloudapi/readonlyapi.go
./provider/tencentcloud/cloudapi/mockapi.go
./provider/tencentcloud/cloudapi/clientset.go
./provider/tencentcloud/cloudapi/api.go
./provider/tencentcloud/cloudapi/tencentapi.go
./provider/tencentcloud/tencent_cloud.go
Error: Process completed with exit code 2.

there's also a conflict with the go.mod now. Can you please fix that @Hyzhou ?

I already add the lisence header. and rebase the code

Raffo · 2022-09-15T08:25:31Z

Approved CI again.

Hyzhou · 2022-09-15T08:32:10Z

Approved CI again.

Sorry, I will run it local.

Signed-off-by: misakazhou <misakazhou@tencent.com>

szuecs · 2022-09-15T09:46:43Z

/approve
/lgtm

k8s-ci-robot · 2022-09-15T09:46:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Hyzhou, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [szuecs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 4, 2022

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 4, 2022

k8s-ci-robot requested review from Raffo and seanmalloy March 4, 2022 09:56

Hyzhou changed the title ~~add the provider for the tencent cloud.~~ Add the provider for the Tencent Cloud. Mar 8, 2022

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 19, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 19, 2022

Hyzhou force-pushed the tencentcloud-provider branch from d2ba0b9 to a6d6e64 Compare August 24, 2022 11:51

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2022

Hyzhou force-pushed the tencentcloud-provider branch 3 times, most recently from 41b88c6 to 10fad34 Compare August 25, 2022 03:09

k8s-ci-robot added the sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. label Aug 25, 2022

k8s-ci-robot assigned szuecs Sep 8, 2022

szuecs reviewed Sep 8, 2022

View reviewed changes

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 8, 2022

k8s-ci-robot assigned Raffo Sep 8, 2022

Hyzhou force-pushed the tencentcloud-provider branch 2 times, most recently from 523ed7b to dce3174 Compare September 11, 2022 13:04

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2022

Hyzhou force-pushed the tencentcloud-provider branch 2 times, most recently from 17cad62 to 4fd48e4 Compare September 15, 2022 08:24

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2022

add the provider for the tencent cloud.

a2e7ffc

Signed-off-by: misakazhou <misakazhou@tencent.com>

Hyzhou force-pushed the tencentcloud-provider branch from 4fd48e4 to a2e7ffc Compare September 15, 2022 08:42

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022

k8s-ci-robot merged commit 78b5175 into kubernetes-sigs:master Sep 15, 2022

Add the provider for the Tencent Cloud. #2630

Add the provider for the Tencent Cloud. #2630

Conversation

Hyzhou commented Mar 4, 2022 • edited Loading

k8s-ci-robot commented Mar 4, 2022

Hyzhou commented Mar 8, 2022 • edited Loading

k8s-triage-robot commented Jun 19, 2022

k8s-triage-robot commented Jul 19, 2022

lostz commented Aug 5, 2022

Hyzhou commented Aug 5, 2022 • edited Loading

lostz commented Aug 6, 2022

ysicing commented Aug 24, 2022

Hyzhou commented Aug 24, 2022 • edited Loading

ysicing commented Aug 24, 2022 • edited Loading

Hyzhou commented Aug 25, 2022

Hyzhou commented Aug 25, 2022

ysicing commented Sep 8, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

szuecs Sep 11, 2022 • edited Loading

Choose a reason for hiding this comment

Hyzhou Sep 11, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hyzhou Sep 11, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

szuecs left a comment

Choose a reason for hiding this comment

szuecs commented Sep 8, 2022

szuecs commented Sep 8, 2022

szuecs commented Sep 8, 2022

Raffo commented Sep 15, 2022

Raffo commented Sep 15, 2022 • edited Loading

Hyzhou commented Sep 15, 2022

Hyzhou commented Sep 15, 2022

Raffo commented Sep 15, 2022

Hyzhou commented Sep 15, 2022

szuecs commented Sep 15, 2022

k8s-ci-robot commented Sep 15, 2022

Hyzhou commented Mar 4, 2022 •

edited

Loading

Hyzhou commented Mar 8, 2022 •

edited

Loading

Hyzhou commented Aug 5, 2022 •

edited

Loading

Hyzhou commented Aug 24, 2022 •

edited

Loading

ysicing commented Aug 24, 2022 •

edited

Loading

szuecs Sep 11, 2022 •

edited

Loading

Hyzhou Sep 11, 2022 •

edited

Loading

Hyzhou Sep 11, 2022 •

edited

Loading

Raffo commented Sep 15, 2022 •

edited

Loading