-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow for automatic documentation creation and publishing #2652
Workflow for automatic documentation creation and publishing #2652
Conversation
/assign @seanmalloy |
/assign @Raffo |
@renehernandez this looks very cool. Before I review this, can you fix the linting issue?
|
@Raffo Update branch with latest master changes and fix the lint complains. Need you to approve again the workflows |
@renehernandez noob question: we are using github pages already for helm releases, would this conflict with that? Is there a way we can make both work? /cc @stevehipwell as well who's our helm expert. |
Based on the mike docs about special files it looks like existing files in the Also I don't think that triggering the action on all tag pushes is correct, I assume that the docs need updating when ExternalDNS is released so the tags filter should be |
@Raffo @stevehipwell I'll replicate the current github pages content in my fork and push a new version to confirm that it doesn't removed them. I'll update the workflow to only run on tags prefixed with |
@Raffo @stevehipwell I've changed the docs workflow filter so it only runs on tags starting with
|
@renehernandez thanks for the update, this is looking good! Please resolve the conflicts so that I can start CI again and we can give this a go, it will be a great addition. |
@Raffo Fixed and ready to merge |
@Raffo Bumping this again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, renehernandez The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Fixes #2562
This PR adds a workflow to automate publishing documentation using:
You can see a running version of this documentation at https://renehernandez.github.io/external-dns/
Workflow details
gh-pages
CONTRIBUTING.md
,code-of-conduct.md
,LICENSE
andREADME
into the docs folder to make them available for the mkdocs build processREADME
/index.md
to remove thedocs/
prefix from the links. It is necessary since after copying into the docs folder the relative path are no longer correctOther Changes
Notes
Checklist