migration to infoblox-go-client/v2 #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
k8s-ci-robot
added
cncf-cla: no
k8s-ci-robot
added
cncf-cla: yes
Raffo
reviewed
Mar 30, 2022
go.mod
Outdated
Comment on lines
30
to
31
| github.com/infobloxopen/infoblox-go-client v1.1.1 | ||
| github.com/infobloxopen/infoblox-go-client/v2 v2.1.1 |
There was a problem hiding this comment.
This has the old client still imported. Is it required?
There was a problem hiding this comment.
No, it is redundant. I will remove it in the next commit.
|
@Raffo Can you please review and approve this PR ? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, skudriavtsev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only about migrating Infoblox provider's code to the latest version of infoblox-go-client.
Checklist