Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI release notes generation #2671

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

stevehipwell
Copy link
Contributor

Description

This PR fixes the chart CI issue with specific characters in the release notes.

Checklist

  • Unit tests updated
  • End user documentation updated

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2022
@stevehipwell
Copy link
Contributor Author

/assign @Raffo

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2022
@stevehipwell
Copy link
Contributor Author

@Raffo after this PR is merged you should be able to create a new workflow on master to release the chart.

@Raffo
Copy link
Contributor

Raffo commented Mar 30, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6d7f465 into kubernetes-sigs:master Mar 30, 2022
@stevehipwell stevehipwell deleted the fix-chart-ci branch March 30, 2022 08:20
@stevehipwell
Copy link
Contributor Author

@Raffo thanks for merging this, could you run a new version of the "Release Chart" action against master to release the pending chart version? Once that is released I'll open the PR for the next chart version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants