-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add target filters based on network #2693
add target filters based on network #2693
Conversation
|
Welcome @tobikris! |
cd31174
to
692f2bb
Compare
/assign @njuettner |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Hey @njuettner, can you please give me an estimate when this PR could be reviewed? Thanks for your time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner, tobikris The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This would be really helpful, if also a PR for filtering for private DNS zones in OCI, would get merged. E.g.: #2673 |
@njuettner any release date for this? |
Description
I have implemented the possibility to filter the targets discovered from sources. My usecase is the OCI loadbalancer that assigns both a private and public IP address to the service. If both are published in public DNS, the record is useless.
You can filter the generated targets by their networks
using
--target-net-filter=10.0.0.0/8
or--exclude-target-net=10.0.0.0/8
.I guess there might be more target filters in the future, which is why I tried to stay as flexible as possible. I tried to add this change to the relevant docs section.
Checklist