extract bluecat api code into its own package #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract all Bluecat Gateway Client code to separate package
Check status codes when API calls are made for gets and deletes. All of the creates were done slightly different and will be updated in a separate commit.
The prefix and suffix for the txt record was not being taken into account when trying to find an owner for a cname and host record. In addition, CName records have to be unique values, therefore txt records need to have either a prefix or suffix included. This fixes the "owner" logic to ensure when checking a corresponding txt recod against a cname record that the prefix or suffix is used when comparing records. Also, correct the response codes for the DELETE calls to Bluecat Gateway
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
|
/assign @seanmalloy I would recommend reviewing this PR commit by commit as this has a lot of refactoring |
Consolidating the HTTP requests into a function will help ensure consistency when making HTTP requests to the Bluecat gateway, and in a future commit will make mocking these requests easier
* Move tests to appropriate package * Add test for SplitProperties function * Remove unused helper function * Use table driven tests
vinny-sabatini
force-pushed
the
issue-2187
branch
from
baa3916
to
d4927b2
Compare
|
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: seanmalloy, vinny-sabatini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was a pretty significant overhaul to the Bluecat provider codebase including:
dry-runmodeFixes #2187
Checklist