Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IBM Cloud provider #2707

Merged
merged 6 commits into from
May 26, 2022
Merged

Add IBM Cloud provider #2707

merged 6 commits into from
May 26, 2022

Conversation

hughhuangzh
Copy link
Contributor

@hughhuangzh hughhuangzh commented Apr 14, 2022 •
edited

Description

this PR adds support for the IBM Cloud provider.
User can use this provider to manage IBM Cloud public/private DNS with external-dns

Fixes #ISSUE

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 14, 2022
@hughhuangzh
Copy link
Contributor Author

/sig cloud-provider

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 14, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 28, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2022
@hughhuangzh
Copy link
Contributor Author

@Raffo @njuettner @seanmalloy anyone of you can help to review, thank!

@hughhuangzh
Copy link
Contributor Author

@Raffo @njuettner @seanmalloy Please approve the workflows, thx!

njuettner
njuettner requested changes May 13, 2022
View reviewed changes
README.md Show resolved Hide resolved
docs/tutorials/ibmcloud.md Outdated Show resolved Hide resolved
docs/tutorials/ibmcloud.md Outdated Show resolved Hide resolved
docs/tutorials/ibmcloud.md Outdated Show resolved Hide resolved
provider/ibmcloud/ibmcloud.go Show resolved Hide resolved
@hughhuangzh
Copy link
Contributor Author

@njuettner comments are addressed, Please check. thank you!

njuettner
njuettner approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hughhuangzh, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit de1db79 into kubernetes-sigs:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hughhuangzh @k8s-ci-robot @njuettner