Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to stable GSS-TSIG API #2719

Merged
merged 3 commits into from
May 6, 2022

Conversation

bodgit
Copy link
Contributor

@bodgit bodgit commented Apr 21, 2022

Description

(Disclaimer: I'm the maintainer of the GSS-TSIG package you're using)

I noticed you were using my package but you're using an old version before the API was stablised and the necessary changes were accepted upstream to the miekg/dns package.

So here's a PR that updates to the most stable version. I've also updated the miekg/dns package, however the release that contains the changes my package requires came one or two releases after they removed support for HMAC-MD5 TSIG signatures so it would affect any users of that algorithm, (although people really shouldn't be using it nowadays).

Thankfully my package also contains an identical HMAC implementation that still supports HMAC-MD5 so I've switched to using that. I also noticed you didn't accept HMAC-SHA224 or HMAC-SHA384 which are both supported algorithms so I permitted both of those too.

Checklist

  • Unit tests updated
  • End user documentation updated

Maintains HMAC-MD5 support with newer versions of github.com/miekg/dns
package.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 21, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @bodgit!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 21, 2022
@seanmalloy
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 22, 2022
@seanmalloy
Copy link
Member

/lgtm
/assign @Raffo @njuettner

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2022
@Raffo
Copy link
Contributor

Raffo commented May 6, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bodgit, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 899cd95 into kubernetes-sigs:master May 6, 2022
@bodgit bodgit deleted the bump-gss-deps branch May 6, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants