-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to stable GSS-TSIG API #2719
Conversation
Maintains HMAC-MD5 support with newer versions of github.com/miekg/dns package.
Welcome @bodgit! |
/kind cleanup |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bodgit, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
(Disclaimer: I'm the maintainer of the GSS-TSIG package you're using)
I noticed you were using my package but you're using an old version before the API was stablised and the necessary changes were accepted upstream to the
miekg/dns
package.So here's a PR that updates to the most stable version. I've also updated the
miekg/dns
package, however the release that contains the changes my package requires came one or two releases after they removed support for HMAC-MD5 TSIG signatures so it would affect any users of that algorithm, (although people really shouldn't be using it nowadays).Thankfully my package also contains an identical HMAC implementation that still supports HMAC-MD5 so I've switched to using that. I also noticed you didn't accept HMAC-SHA224 or HMAC-SHA384 which are both supported algorithms so I permitted both of those too.
Checklist