fix: remove split of host/port #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
scottd018
changed the title
scottd018
force-pushed
the
fix-missing-port
branch
from
3728e4f
to
6d800e3
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
This commit removes the need to split the host and port as the dns client configuration was refactored in v0.12.0 to no longer require this. Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
scottd018
force-pushed
the
fix-missing-port
branch
from
6d800e3
to
604117b
Compare
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo, scottd018 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the need to split the host and port as the
dns client configuration was refactored in v0.12.0 to no longer
require this.
Signed-off-by: Dustin Scott sdustin@vmware.com
Description
This removes the need to split the host and port. The refactor that went into v0.12.0 changed the methodology that was used to create the handle and now no longer requires the hostname separated from the port.
Fixes #2778
Checklist
NOTE: docs not required to be updated. Unit tests are sufficiently complex that it would not make sense to put it in this PR (unit tests require a functional KDC server to interact with) - opened issue #2784 to address this.