-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfc2136: remove deprecated MD5 key algorithm #2803
Conversation
Welcome @jacksgt! |
/assign @njuettner |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
This PR is still valid. Could someone take a look please? /remove-lifecycle stale |
/assign @njuettner
…On 9 June 2022 11:59:23 CEST, Kubernetes Prow Robot ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is **NOT APPROVED**
This pull-request has been approved by: *<a href="#2803#" title="Author self-approved">jacksgt</a>*
To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **njuettner** after the PR has been reviewed.
You can assign the PR to them by writing `/assign @njuettner` in a comment when ready.
The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes-sigs%2Fexternal-dns).
<details open>
Needs approval from an approver in each of these files:
- **[OWNERS](https://github.com/kubernetes-sigs/external-dns/blob/master/OWNERS)**
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
</details>
<!-- META={"approvers":["njuettner"]} -->
--
Reply to this email directly or view it on GitHub:
#2803 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Signed-off-by: Jack Henschel <jack.henschel@cern.ch>
e6e0841
to
3ed2264
Compare
Rebased as required. Could someone please take a look? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacksgt, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jack Henschel jack.henschel@cern.ch
Description
This patch removes the deprecated
hmac-md5
TSIG algorithm from the supported list.The
dns
library used by the RFC2136 provider no longer supports this algorithm: https://github.com/miekg/dns/pull/1187/filesUsers are currently experiencing the following error message (at runtime!) when configuring external-dns with this algorithm:
Checklist