rfc2136: remove deprecated MD5 key algorithm

[jacksgt]

Signed-off-by: Jack Henschel jack.henschel@cern.ch

Description

This patch removes the deprecated hmac-md5 TSIG algorithm from the supported list.
The dns library used by the RFC2136 provider no longer supports this algorithm: https://github.com/miekg/dns/pull/1187/files

Users are currently experiencing the following error message (at runtime!) when configuring external-dns with this algorithm:

failed to fetch records via AXFR: dns: bad key algorithm

Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

Welcome @jacksgt!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[jacksgt]

/assign @njuettner

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[jacksgt]

This PR is still valid. Could someone take a look please?

/remove-lifecycle stale

[jacksgt]

/assign @njuettner

…

On 9 June 2022 11:59:23 CEST, Kubernetes Prow Robot ***@***.***> wrote: [APPROVALNOTIFIER] This PR is **NOT APPROVED** This pull-request has been approved by: *<a href="#2803#" title="Author self-approved">jacksgt</a>* To complete the [pull request process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process), please assign **njuettner** after the PR has been reviewed. You can assign the PR to them by writing `/assign @njuettner` in a comment when ready. The full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes-sigs%2Fexternal-dns). <details open> Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/external-dns/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment </details> <!-- META={"approvers":["njuettner"]} --> -- Reply to this email directly or view it on GitHub: #2803 (comment) You are receiving this because you were mentioned. Message ID: ***@***.***>

[jacksgt]

Rebased as required.

Could someone please take a look?

@szuecs

[szuecs]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacksgt, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [szuecs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment