Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support ExternalID in AWS Provider when assuming a role #2818

Merged
merged 15 commits into from
Aug 19, 2022
Merged

support ExternalID in AWS Provider when assuming a role #2818

merged 15 commits into from
Aug 19, 2022

Conversation

PG2000
Copy link
Contributor

@PG2000 PG2000 commented Jun 15, 2022

Description

Support ExternalID in AWS Provider when assuming a role.

This is a follow up for the pull request which is closed.
Thanks for the work of @dylwylie which i just copy & pasted

Checklist

  • Unit tests updated
  • End user documentation updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 15, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: PG2000 / name: pg2000 (2a1b79e)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 15, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 15, 2022
@PG2000
Copy link
Contributor Author

PG2000 commented Jun 17, 2022

/assign @njuettner

seh
seh reviewed Jun 27, 2022
View reviewed changes
Copy link
Contributor

@seh seh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Id/ID/g

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
pkg/apis/externaldns/types.go Outdated Show resolved Hide resolved
pkg/apis/externaldns/types.go Outdated Show resolved Hide resolved
pkg/apis/externaldns/types.go Outdated Show resolved Hide resolved
pkg/apis/externaldns/types_test.go Outdated Show resolved Hide resolved
provider/aws/aws.go Outdated Show resolved Hide resolved
provider/aws/aws.go Outdated Show resolved Hide resolved
provider/awssd/aws_sd.go Outdated Show resolved Hide resolved
provider/awssd/aws_sd.go Outdated Show resolved Hide resolved
PG2000 and others added 11 commits June 27, 2022 20:55
@PG2000 @seh
replace Id with ID
a05e502 
Co-authored-by: Steven E. Harris <seh@panix.com>
@PG2000 @seh
replace Id with ID
3c5b1f9 
Co-authored-by: Steven E. Harris <seh@panix.com>
@PG2000 @seh
replace Id with ID
d327ff7 
Co-authored-by: Steven E. Harris <seh@panix.com>
@PG2000 @seh
replace Id with ID
026e15b 
Co-authored-by: Steven E. Harris <seh@panix.com>
@PG2000 @seh
replace Id with ID
fd68732 
Co-authored-by: Steven E. Harris <seh@panix.com>
@PG2000 @seh
replace Id with ID
ff56bf8 
Co-authored-by: Steven E. Harris <seh@panix.com>
@PG2000 @seh
replace Id with ID
52c8ede 
Co-authored-by: Steven E. Harris <seh@panix.com>
@PG2000 @seh
replace Id with ID
ca99ed0 
Co-authored-by: Steven E. Harris <seh@panix.com>
@PG2000 @seh
replace Id with ID
ff46c40 
Co-authored-by: Steven E. Harris <seh@panix.com>
@PG2000 @seh
replace Id with ID
e1e48f8 
Co-authored-by: Steven E. Harris <seh@panix.com>
@PG2000 @seh
replace Id with ID
4d0be69 
Co-authored-by: Steven E. Harris <seh@panix.com>
@PG2000
Copy link
Contributor Author

PG2000 commented Jul 26, 2022

@seh can we proceeed with this PR?

@PG2000
Copy link
Contributor Author

PG2000 commented Aug 5, 2022

@njuettner can we proceed with this?

@PG2000 @njuettner
Update pkg/apis/externaldns/types.go
03a28ee 
Co-authored-by: Nick Jüttner <nick@juni.io>
njuettner
njuettner reviewed Aug 19, 2022
View reviewed changes
provider/aws/aws.go Outdated Show resolved Hide resolved
provider/aws/aws.go Outdated Show resolved Hide resolved
provider/aws/aws.go Show resolved Hide resolved
PG2000 and others added 2 commits August 19, 2022 17:08
njuettner
njuettner approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, PG2000, seh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1f0f004 into kubernetes-sigs:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seh seh seh approved these changes

@njuettner njuettner njuettner approved these changes

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PG2000 @k8s-ci-robot @seh @njuettner