Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to UK Fast after merge with ANS group #2842

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Update references to UK Fast after merge with ANS group #2842

merged 4 commits into from
Jul 13, 2022

Conversation

rjhenry
Copy link
Contributor

@rjhenry rjhenry commented Jun 23, 2022

Description

Following the UKFast merge with ANS group, the URL for GitHub repositories has been changed. While GitHub will redirect to the correct place, it makes sense to update references to avoid confusion going forward.

Checklist

  • Unit tests updated
  • End user documentation updated

UKFast have recently merged with ANS group [1] and have started to
rename GitHub repositories. While GitHub will redirect repository
accesses, it makes more sense to use the canonical URL going forward.

As part of this, the versions have been updated to reflect their new
module names [2] [3].

1: https://www.ans.co.uk/campaigns/ukfast-is-now-ans/
2: https://github.com/ans-group/go-durationstring/releases/tag/v1.2.0
3: https://github.com/ans-group/sdk-go/releases/tag/v1.7.0

Signed-off-by: Rick Henry <rick.henry@assureddigitaltech.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 23, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 23, 2022
@rjhenry rjhenry marked this pull request as ready for review June 23, 2022 15:48
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2022
Rick Henry added 3 commits June 23, 2022 22:02
Signed-off-by: Rick Henry <rick.henry@assureddigitaltech.com>
Note that some URLs were not updated, as there is not yet equivalent
pages on the `ans.co.uk` domain.

Signed-off-by: Rick Henry <rick.henry@assureddigitaltech.com>
Signed-off-by: Rick Henry <rick.henry@assureddigitaltech.com>
@Raffo
Copy link
Contributor

Raffo commented Jul 13, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo, rjhenry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit beb7495 into kubernetes-sigs:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants