-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set logformat before logging config #2847
Conversation
Google Cloud Logging (AKA Stackdriver Logs) interprets the default logrus log format as "error" severity even when `level=info` is present in the log output: ensure that the normal startup log is not parsed as an error by setting the JSON formatter first. Signed-off-by: Nathan J Mehl <n@oden.io>
Welcome @n-oden! |
/assign @Raffo |
/lgtm |
@Raffo @seanmalloy ping? :) |
Hey folks, it's been a while here. This is a very small PR -- any chance of getting it merged? |
@Raffo @JAORMX @seanmalloy @njuettner ping? :) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JAORMX, n-oden, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! |
Description
Google Cloud Logging (AKA Stackdriver Logs) interprets the default
logrus log format as "error" severity even when
level=info
ispresent in the log output: ensure that the normal startup log
is not parsed as an error by setting the JSON formatter first.
Checklist
Signed-off-by: Nathan J Mehl n@oden.io