-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Civo DNS as a new provider #2852
Conversation
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
/assign @seanmalloy |
@alejandrojnm it looks like you've got a partial rebase/merge artefact in Chart.yaml which you might want to clean up. |
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
@stevehipwell fixed, sorry for that |
@alejandrojnm thanks for fixing that. It also looks like you've got the same problem in go.mod. |
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
@stevehipwell fixed |
@stevehipwell I need to do something else ?? |
@njuettner could you review this? |
Hi, @stevehipwell @njuettner any update on this? |
Hi @stevehipwell @njuettner ??? |
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
+1 I was missing this as I was preparing for https://kubehuddle.com/2022/#speaker-gerhard-lazu & ended up hand-rolling my own solution. I look forward to using this part of external-dns. Thank you @alejandrojnm for opening this PR! |
Hi, @drzewo @njuettner any update on this ?? |
@alejandrojnm, I'm just a passenger waiting for the train (this feature) to arrive. Maybe @njuettner can do something about proceeding this PR past some missing workflow approvals? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments, also it would be great if we can expand a little the test coverage (it's 78% now, there's probably room for improvement).
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
@alejandrojnm thanks for the updates. There are currently issues with code in |
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
Hi @Raffo let me know if is ok in this way |
@alejandrojnm I still see that in |
I will check that right now |
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
@Raffo ready for review |
@alejandrojnm tests are failing. |
I'm looking, but i run locally and work Running tool: /usr/local/go/bin/go test -timeout 30s -run ^TestCivoProviderRecords$ sigs.k8s.io/external-dns/provider/civo
=== RUN TestCivoProviderRecords
--- PASS: TestCivoProviderRecords (0.00s)
PASS
ok sigs.k8s.io/external-dns/provider/civo |
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alejandrojnm, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Request to add Civo as a new provider for external-dns
Checklist