Infoblox - Correct GetObject query

[skalpin]

Description

The ibclient.GetObject will return all the objects associated with the query. This is an issue when external-dns has identified 1 record to remove. The object being created retrieves many more records than expected and so external-dns will delete all the matching records.

This change adds one "name" filter to the query parameters so that only the expected record is removed from infoblox

Checklist

• Unit tests updated
• End user documentation updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: skalpin / name: Steve Kalpin (59f4f1c)

[skalpin]

/assign @njuettner

[njuettner]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, skalpin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [njuettner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RichieSams]

Can we get a release for this fix and a huge warning on all releases before this fix?
We got hit by this issue, and external-dns deleted 4000 DNS records that it didn't own....

[torbendury]

+1, we need a hotfix release for this. Completely messed up our infoblox.

[RichieSams]

@seanmalloy @njuettner @Raffo Do you all have any ETA for when a new release will be created with this fix?

[RichieSams]

@zreigz Do you know when the next release will be? This fix is sorely needed. As it stands, we can't upgrade external-dns due to this issue.

[zreigz]

@zreigz Do you know when the next release will be? This fix is sorely needed. As it stands, we can't upgrade external-dns due to this issue.

sorry, I am the wrong person for this

[RichieSams]

sorry, I am the wrong person for this

Ah apologies. I saw your name in the commits. Thanks for your other work! :)