Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Plural DNS provider #2923

Merged
merged 8 commits into from
Sep 15, 2022
Merged

feat: Add Plural DNS provider #2923

merged 8 commits into from
Sep 15, 2022

Conversation

davidspek
Copy link
Contributor

Description
This PR adds the Plural DNS provider to external DNS.

Background

Plural is a platform that deploys open source applications on Kubernetes in your cloud using common standards like Helm and Terraform.

The Plural platform provides the following:

  • Dependency management between Terraform/Helm modules, with dependency-aware deployment and upgrades.
  • Authenticated docker registry and chartmuseum proxy per repository.
  • Secret encryption using AES-256 (so you can keep the entire workflow in git).

In addition, Plural also handles:

  • Issuing the certificates.
  • Configuring a DNS service to register fully-qualified domains under onplural.sh to eliminate the hassle of DNS registration for users.
  • Being an OIDC provider to enable zero touch login security for all Plural applications.

Checklist

  • Unit tests updated
  • End user documentation updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 1, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 1, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @davidspek!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 1, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 1, 2022
@davidspek
Copy link
Contributor Author

/assign @njuettner @seanmalloy

@davidspek
Copy link
Contributor Author

/assign @Raffo

@davidspek
Copy link
Contributor Author

/assign @szuecs

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 20, 2022
szuecs
szuecs reviewed Aug 24, 2022
View reviewed changes
go.mod Outdated
)

replace k8s.io/klog/v2 => github.com/Raffo/knolog v0.0.0-20211016155154-e4d5e0cc970a

replace github.com/Yamashou/gqlgenc => github.com/pluralsh/gqlgenc v0.0.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you clarify this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we had to fork this library because it uses some custom JSON parser that throws nil pointer exception when trying to unmarshal our GraphQL schema:
Yamashou/gqlgenc#141

We can try to contribute to this library and fix the issue but it's not simple and can take some time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szuecs right now the problem is fixed in the github.com/Yamashou/gqlgenc library and this line is not needed anymore

szuecs
szuecs reviewed Aug 24, 2022
View reviewed changes
provider/plural/client.go Outdated
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be dropped as there is a CLA you sign.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

szuecs
szuecs reviewed Aug 24, 2022
View reviewed changes
provider/plural/client.go
func (c *Config) BaseUrl() string {
host := "https://app.plural.sh"
if c.Endpoint != "" {
host = fmt.Sprintf("https://%s", c.Endpoint)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better make sure that it's actually an URL, so url.Parse and handle error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@szuecs
Copy link
Contributor

szuecs commented Aug 24, 2022

looks fine to me in general some small things (besides the replace directive which should be clear why and documented).
The bigger issue is that we are a bit worried about the number of providers. We will discuss how to proceed in our maintainers meeting. End of September we should have a comment that tells more about how we want to proceed with new providers.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 7, 2022
@zreigz
Copy link
Contributor

zreigz commented Sep 7, 2022

@szuecs PTAL

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2022
davidspek and others added 3 commits September 15, 2022 14:48
@davidspek @zreigz
Implement plural provider
62848b5 
add plural to provider enum

go mod tidy

remove gitlab-ci

Signed-off-by: DavidSpek <vanderspek.david@gmail.com>

cleanup

Signed-off-by: DavidSpek <vanderspek.david@gmail.com>
@davidspek @zreigz
Add Plural to READMEs
d70e4bc 
Signed-off-by: DavidSpek <vanderspek.david@gmail.com>
@zreigz
migrate to GO plural client (#10)
3f5ea38
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2022
@szuecs
Copy link
Contributor

szuecs commented Sep 15, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidSpek, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@szuecs
Copy link
Contributor

szuecs commented Sep 15, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit a763843 into kubernetes-sigs:master Sep 15, 2022
@Miciah Miciah mentioned this pull request Nov 11, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szuecs szuecs szuecs left review comments

@zreigz zreigz zreigz left review comments

@njuettner njuettner Awaiting requested review from njuettner

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@szuecs szuecs

@Raffo Raffo

@seanmalloy seanmalloy

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@davidspek @k8s-ci-robot @szuecs @zreigz @Raffo @seanmalloy @njuettner