Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Azure SDK and remove deprecated autorest dependency #3040

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Update Azure SDK and remove deprecated autorest dependency #3040

merged 4 commits into from
Sep 1, 2023

Conversation

phillebaba
Copy link
Contributor

@phillebaba phillebaba commented Sep 22, 2022 •
edited

Description

This PR updates the Azure SDK to the latest stable version and replaces the use of the deprecated autorest with azidentity.

Fixes #3211

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 22, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 22, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @phillebaba!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 22, 2022
@phillebaba phillebaba marked this pull request as draft September 22, 2022 15:36
@phillebaba phillebaba mentioned this pull request Oct 14, 2022
Merged
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2022
@phillebaba phillebaba force-pushed the feature/azure-sdk branch 4 times, most recently from f7b0f97 to ef47d7f Compare December 1, 2022 16:59
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 1, 2022
@phillebaba phillebaba force-pushed the feature/azure-sdk branch 3 times, most recently from 026e5fe to 5fd7eb1 Compare December 2, 2022 10:10
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 2, 2022
phillebaba
phillebaba commented Dec 2, 2022
View reviewed changes
provider/azure/config_test.go
}{
"AzureChinaCloud": {"AzureChinaCloud", nil},
"AzureGermanCloud": {"AzureGermanCloud", nil},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

German Cloud does not exist anymore so it has been removed from the configuration.
Azure/azure-sdk-for-go#19112

@phillebaba phillebaba marked this pull request as ready for review December 2, 2022 11:17
@phillebaba phillebaba mentioned this pull request Dec 2, 2022
Closed
2 tasks
@phillebaba phillebaba changed the title WIP: Update Azure SDK and remove deprecated autorest dependency Update Azure SDK and remove deprecated autorest dependency Dec 2, 2022
@weisdd weisdd mentioned this pull request Jul 3, 2023
Closed
@mloiseleur
Copy link
Contributor

@phillebaba Do you think you can rebase this PR ? The CI is now fixed.

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 10, 2023
@phillebaba phillebaba force-pushed the feature/azure-sdk branch 2 times, most recently from 1c8208f to 5ca126f Compare August 10, 2023 13:18
@mloiseleur
Copy link
Contributor

mloiseleur commented Aug 10, 2023 •
edited

@phillebaba I left one small suggestion on error handling, otherwise it LGTM.

johngmyers
johngmyers suggested changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note that support for AAAA records is noticeably absent. Not blocking.

provider/azure/azure.go Outdated Show resolved Hide resolved
provider/azure/azure_private_dns.go Outdated Show resolved Hide resolved
phillebaba and others added 3 commits August 15, 2023 09:05
@phillebaba @johngmyers
Update provider/azure/azure.go
d42df08 
Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
@phillebaba @johngmyers
Update provider/azure/azure_private_dns.go
55c93e7 
Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
@phillebaba @mloiseleur
Update provider/azure/config.go
985a532 
Co-authored-by: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com>
@mloiseleur
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2023
@nbjohnson
Copy link

Excited to see there is movement on this MR, can't wait for this feature to be available. Do we know when a release might occur with this feature included?

@jbpaux
Copy link
Contributor

jbpaux commented Aug 29, 2023

@mloiseleur @johngmyers can any of you put the approved tag ? 😅

@johngmyers
Copy link
Contributor

Neither of us is an approver

@bizrad
Copy link

bizrad commented Aug 30, 2023

@jbpaux the bot above says that now that the LGTM tag is added we need to ask @Raffo for approval here

@Raffo
Copy link
Contributor

Raffo commented Sep 1, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phillebaba, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2023
@Raffo
Copy link
Contributor

Raffo commented Sep 1, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 6244c44 into kubernetes-sigs:master Sep 1, 2023
14 checks passed
@weisdd weisdd mentioned this pull request Sep 1, 2023
Merged
2 tasks
@nbjohnson nbjohnson mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur left review comments

@johngmyers johngmyers johngmyers requested changes

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

@szuecs szuecs Awaiting requested review from szuecs

@njuettner njuettner Awaiting requested review from njuettner

Assignees

@Raffo Raffo

@johngmyers johngmyers

@mloiseleur mloiseleur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Azure DNS provider to newer SDK