-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple records per A record in OpenStack Designate Provider #3049
Allow multiple records per A record in OpenStack Designate Provider #3049
Conversation
Welcome @hikhvar! |
Fetch labels from existing TXT records to fix kubernetes-sigs#603
611be96
to
b1e6627
Compare
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@Raffo @njuettner would be awesome to have this addition in the Designate provider. Could you kindly look into this change? |
/remove-lifecycle stale |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hikhvar, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Allow multiple records per A record. Therefore update the Delete and Create order so, we don't delete a single old record value.
Before this patch, external-dns alternated between two IPs as record values if upgraded from a single record to two A records.
Fetch labels from existing TXT records to fix https://github.com/kubernetes-sigs/external-dns/issues/
Fixes #603
Checklist