reorder cloudflare updates to delete before create #3094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an A or CNAME record must be changed, in the current state the provider attempts to create a record then delete the old record. The create fails due to there being an existing A/CNAME record with that name, and then the delete succeeds, leaving the name unresolvable until the next time the external-dns loop runs.
By doing the delete first, this issue is mitigated. While not as elegant as using UPDATE calls, it is a lot simpler.
Attempts to remediate #2820 and (to some extent) #2435
Checklist