Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pi-Hole Local DNS Support - rebases #2321 #3125

Merged
merged 7 commits into from
Nov 10, 2022
Merged

Pi-Hole Local DNS Support - rebases #2321 #3125

merged 7 commits into from
Nov 10, 2022

Conversation

anubisg1
Copy link
Contributor

@anubisg1 anubisg1 commented Oct 31, 2022

This adds support for synchronizing DNS records with a Pi-Hole Local DNS instance. I've only put it through limited testing so far locally, so if there are others who want to try it out too to help catch edge cases that would be super helpful, but probably not an immediate priority.

I'm happy to help maintain this provider, but I can't make a guarantee on

It would be nice if the maintainers run the provider in production

Mainly, because I think I'd rather go sky diving out of a low-flying Cessna before attempting to actually do that. BUT! I am more than happy to continue to run this in my homelab if it continues to prove itself useful.

Addresses #1930

rebases and obsoletes #2321

Checklist
Checklist

  • [x ] Unit tests updated
  • [x ] End user documentation updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 31, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 31, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @anubisg1!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 31, 2022
@anubisg1 anubisg1 mentioned this pull request Oct 31, 2022
2 tasks
@szuecs
Copy link
Contributor

szuecs commented Nov 3, 2022

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@szuecs
Copy link
Contributor

szuecs commented Nov 3, 2022

/assign @Raffo

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 7, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 7, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 7, 2022
@anubisg1
Copy link
Contributor Author

anubisg1 commented Nov 8, 2022

@szuecs i fixed a lint issue, might need another approval to run the workflows.
thank you

@szuecs
Copy link
Contributor

szuecs commented Nov 9, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anubisg1, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@szuecs
Copy link
Contributor

szuecs commented Nov 10, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8b8f175 into kubernetes-sigs:master Nov 10, 2022
@davinkevin
Copy link

🎉🎉🎉🎉🎉

Really happy to see it merged. Next step, the release!

@reesericci
Copy link

yay!

@siredmar
Copy link

@szuecs can you tell us when this gets released?

@Skaronator Skaronator mentioned this pull request Jun 5, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants