fix: Support conversion from/to simple to/from other routing policies for the AWS provider.

[jessegonzalez]

Description
This PR allows Route53 record updates to change the routing policy to/from simple from/to other routing policies. These record modifications do not support UPSERT, but instead, require DELETE/CREATE to succeed.

The AWS provider function createUpdateChanges has been updated with another conditional to test if one of the old/new set identifiers is the empty string and the other is not.

The AWS Provider test TestAWSApplyChanges has been updated to validate the change.

While examining what should be changed, I identified that the AWS provider function UpdateRecords is unused, and may be a candidate for removal. If desired I can address that here as well.

Fixes #3141

Checklist

• Unit tests updated
• End user documentation updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: jessegonzalez / name: Jesse Gonzalez (606ce34)

[k8s-ci-robot]

Welcome @jessegonzalez!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[jessegonzalez]

/easycla

[nitrocode]

@szuecs could you please review this? I'd love to see route53 records converted from simple to weighted 🙏

[nitrocode]

/approve

[nitrocode]

cc: @njuettner and cc: @seanmalloy please review when you get a chance. At the moment, our workaround is to clickops a simple routing record into a weighted record with the same set identifier as external-dns is trying to create in order to get it to resolve correctly. This change will prevent us from having to do the workaround.

[szuecs]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jessegonzalez, nitrocode, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [szuecs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nitrocode]

Thank you @szuecs ! Please let us know if there will be a patch release planned. We're very eager for the new version 😄

[szuecs]

I never did a release, but @Raffo will likely do one as soon as the plugin provider is ready

[Raffo]

This broke CI. It's the second time this happens in the past 2 weeks. I'm gonna have to revert.

[nitrocode]

Hmm. I see how the action failed ci.

How come the ci didn't fail tests in this pr? Does ci only run on prs after merge and not as a pr check itself?

The ci checks looks like they should run on pr.

external-dns/.github/workflows/ci.yml

Lines 3 to 7 in 0fcfb29

	on:
	push:
	branches: [ master ]
	pull_request:
	branches: [ master ]

[szuecs]

@nitrocode it was my fault, because I can merge but I had not yet the rights to run tests and missed to ask for test run.