Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow pod IPs even for non-hostNetwork pods #3174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: allow pod IPs even for non-hostNetwork pods #3174

wants to merge 2 commits into from
+108 −21

Commits on Dec 21, 2023

  1. feat: allow pod IPs even for non-hostNetwork pods 

    but only for the internalHostnameAnnotationKey which doesn't use the node's IP anyway
tests validate this for annotations with:
- mixing pods in the host network with others that are not
- multiple comma separated annotations per Pod
- explicitly set targets
- IPv4 and IPv6
    @peterhoneder
    peterhoneder committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    1b9c3bd View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. fixed review comments 

    - incorporated changes from PR kubernetes-sigs#3468 to allow for arbitrary annotations
  to be used no matter the hostNetwork property's value
- updated docs to make clear how the annotations are used for pods
    @peterhoneder
    peterhoneder committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    27e2581 View commit details
    Browse the repository at this point in the history