-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readding Hetzner provider #3192
Readding Hetzner provider #3192
Conversation
|
Welcome @DrBu7cher! |
@DrBu7cher count me in! Let me know if I also need to sign the CLA. |
@jobstoit |
I guess I misunderstood what the OWNERS files does - we cannot simply sign the CLA, we need to be added as members, as mentioned here. |
In my case, I would at least miss a "sponsor" and also the required contributions for becoming a member. |
@DrBu7cher I also signed the CLA. |
@DrBu7cher can't you change the commit messages? Or even revert/reset all those commits. |
Signed-off-by: Pulak Kanti Bhowmick <pkbhowmick007@gmail.com>
Signed-off-by: Pulak Kanti Bhowmick <pkbhowmick007@gmail.com>
Bumps [sigs.k8s.io/gateway-api](https://github.com/kubernetes-sigs/gateway-api) from 0.5.0 to 0.5.1. - [Release notes](https://github.com/kubernetes-sigs/gateway-api/releases) - [Changelog](https://github.com/kubernetes-sigs/gateway-api/blob/main/CHANGELOG.md) - [Commits](kubernetes-sigs/gateway-api@v0.5.0...v0.5.1) --- updated-dependencies: - dependency-name: sigs.k8s.io/gateway-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.119 to 1.44.136. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Commits](aws/aws-sdk-go@v1.44.119...v1.44.136) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Shuwei Hao <haoshuwei24@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DrBu7cher The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I know that there is a lot to merge right now, but can I get an estimate on when this will be looked at? |
@DrBu7cher I'm also very curious about this proposal: #3063. That'd make it easier to self manage a Hetzner ExternalDNS plugin. I hope that they'll soon be able to implement such a generic plugin provider. Once they have that we could have our own repository to maintain |
@DrBu7cher: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Somewhat related, and maybe useful as prior art / inspiration: https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler/cloudprovider/externalgrpc |
thanks for the PR we will not review/merge any new providers. We are working on a plugin provider which will enable you to integrate via webhook. All or most providers will be moved out of tree after plugin #3063 provider was created and we are sure that we can run a major provider out of tree. |
1 similar comment
thanks for the PR we will not review/merge any new providers. We are working on a plugin provider which will enable you to integrate via webhook. All or most providers will be moved out of tree after plugin #3063 provider was created and we are sure that we can run a major provider out of tree. |
Hey, |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
+1 |
is there a sample implementation or a swagger definition to see which parameters this api endpoints support? https://github.com/kubernetes-sigs/external-dns/blob/master/docs/tutorials/webhook-provider.md looks to me only from this documentation its pretty hard to develop a sidecar container for the dns provider of choice |
You can refer to https://github.com/ionos-cloud/external-dns-ionos-webhook. |
i see hetzner dns webhook is already in the making https://github.com/mconfalonieri/external-dns-hetzner-webhook |
I'm going to close this one as v0.14.0 released officially the webhook and hetzner support can be provided through that. |
Description
This PR is to (re)add the support for Hetzner Cloud DNS as provider for external-dns. It still has room for improvement, since it does not make use of the bulk-edit or bulk-create feature of Hetzner Cloud DNS, but nevertheless I want to open this PR here for others to contribute ideas or test more advanced stuff, if they want to.
I'm currently using this provider in my "personal production environment" and it's doing it's job.
I would volunteer as maintainer for this provider integration
Maybe @jobstoit, the creator of the client library used in the provider integration, is interested in this too, but I'm not sure.
If I forgot something, please let me know.
Best regards,
Jonas
Checklist