Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI linting fixes #3205

Merged
merged 13 commits into from
Dec 2, 2022
Merged

CI linting fixes #3205

merged 13 commits into from
Dec 2, 2022

Conversation

Raffo
Copy link
Contributor

@Raffo Raffo commented Nov 30, 2022 •
edited

Description

This PR contains some linting fixes. I am ignoring changes to the azure provider as those require adjustment in code and I will be doing them in a separate PR.

Basing on https://github.com/kubernetes-sigs/external-dns/actions/runs/3586738470/jobs/6036296019, I will do fixes in the codebase to address them.

Fixed #3194

@Raffo
ci linting fixes
a4c1445 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2022
@Raffo
remove staticcheck
a185288 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
disable naming rule
43147ce 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2022
@Raffo Raffo added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 1, 2022
@Raffo
disable stylecheck too
4a29b7a 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2022
@Raffo
linter errors fixes
560f6d9 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2022
@Raffo
re-add staticcheck
e881176 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
fixes various linting issues
64a2f17 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 2, 2022
@Raffo
fix imports
a126f80 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
fix tlsconfig
38d0b7f 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
fix alibabacloud
b3c2595 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
ioutil fixes
3380220 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo
remove all references to ioutil
6e00b27 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2022
@Raffo
ignore linting for azure deprecated sdk
cdfa5fc 
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@Raffo Raffo marked this pull request as ready for review December 2, 2022 18:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2022
@Raffo
Copy link
Contributor Author

Raffo commented Dec 2, 2022

@szuecs @njuettner this is ready to go.

@Raffo Raffo mentioned this pull request Dec 2, 2022
Closed
njuettner
njuettner approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 31e6bb8 into master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

@vinny-sabatini vinny-sabatini Awaiting requested review from vinny-sabatini

Assignees

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assess output of other linters to improve the codebase
3 participants
@Raffo @k8s-ci-robot @njuettner