Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for ClouDNS as a DNS Provider #3262

Closed
wants to merge 19 commits into from
Closed

Add Support for ClouDNS as a DNS Provider #3262

wants to merge 19 commits into from

Conversation

wmarchesi123
Copy link

Description

Adds support for ClouDNS as a DNS provider for External-DNS.

Fixes #3132

Checklist

  • Unit tests updated
  • End user documentation updated

@wmarchesi123
Work on Creating ClouDNS Provider
0ffec42 
Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
NewClouDNSProvider Func Implemented
dd0c446 
Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
Return all Record IDs
1f298ab 
Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
Return Endpoints
3513f26 
Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
Apply Changes Structure
580abf7 
Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
+ Create Complete
b9fea01 
+ Delete Works on all but root (@)

Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
+ Log to debug record matching func
b87a510 
Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
+ Working Create and Delete
e8fa685 
+ Needs Major Refactoring

Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
+ Fully Working Create and Delete
7fddc8e 
Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
+ Complete GoDoc Comments
710cfc4 
Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
+ Remove Extra Log Line
7207f42 
Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
+ Bugfix for Unit Tests
8ece3ba 
Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
+ 25% Coverage
1501fff 
Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
+ Update Code for Test Writing
a09c4a1 
Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
+ Replace last uses of external calls
8a28377 
+ Update zoneRecordMap Function

Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
+ Base Testing Coverage
a3158cc 
+ First Test w Mocked Call

Signed-off-by: William Marchesi <will@marchesi.io>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wmarchesi123
Once this PR has been reviewed and has the lgtm label, please assign seanmalloy for approval by writing /assign @seanmalloy in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 24, 2022
@wmarchesi123
+ Split Helper Functions to New File
2427172 
Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
+ Add Test for merge Endpoints
a9ee47b 
Signed-off-by: William Marchesi <will@marchesi.io>
@wmarchesi123
+ Add GoDoc to Test
ce78d6f 
Signed-off-by: William Marchesi <will@marchesi.io>
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2023
@k8s-ci-robot
Copy link
Contributor

@wmarchesi123: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jon4hz
Copy link

jon4hz commented Feb 25, 2023

Hey :)
Thanks a lot for this PR! I'd absolutely love to use external-dns with cloudns. May I ask what the status is here - aka what is required to get this merged? 🤔

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 25, 2023
@mloiseleur
Copy link
Contributor

We won't merge any new providers. See #3063.
You are more than welcome to (re)use this PR to publish a webhook provider for external-dns.
=> I'm closing this PR.
/close

@k8s-ci-robot
Copy link
Contributor

@mloiseleur: Closed this PR.

In response to this:

We won't merge any new providers. See #3063.
You are more than welcome to (re)use this PR to publish a webhook provider for external-dns.
=> I'm closing this PR.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner Awaiting requested review from njuettner

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. new-provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClouDNS provider support
6 participants
@wmarchesi123 @k8s-ci-robot @jon4hz @k8s-triage-robot @mloiseleur @Raffo