Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway-api: upgrade from v0.5.1 to v0.6.0 and add GRPCRoute support #3268

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

abursavich
Copy link
Contributor

@abursavich abursavich commented Dec 28, 2022

Description

This upgrades sigs.k8s.io/gateway-api from v0.5.1 to v0.6.0 and adds support for GRPCRoutes.

Note: Updating the sigs.k8s.io/gateway-api package also updates the k8s.io/api package, which included a breaking change to the k8s.io/api/networking/v1.IngessStatus type. I included this upgrade and its fix in a separate commit.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 28, 2022
@abursavich abursavich changed the title gateway-api: upgrade from v0.5.1 to v0.6.0 gateway-api: upgrade from v0.5.1 to v0.6.0 and add GRPCRoute support Dec 28, 2022
@abursavich abursavich force-pushed the gateway-api-0.6 branch 2 times, most recently from a6b7cd0 to 4491d90 Compare December 29, 2022 01:49
@abursavich
Copy link
Contributor Author

Unfortunately, these change are going to collide with #3271. Let's try to get #3271 through first, and then I'll come back and rebase this one.

Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 4, 2023
@njuettner njuettner removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
@njuettner
Copy link
Member

@abursavich Merged the other PR, do you mind doing a rebase 🙏🏻. Thank you ❤️

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 4, 2023
@abursavich
Copy link
Contributor Author

thanks, @njuettner. rebased.

@abursavich abursavich requested review from njuettner and removed request for szuecs and seanmalloy January 5, 2023 02:00
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abursavich, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njuettner
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8d39464 into kubernetes-sigs:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants