Update cloudflare-go to 0.58.1

[arturhoo]

Description

Update cloudflare-go to the latest version.
There are breaking changes between 0.50.0 and 0.58.0 introduced in cloudflare/cloudflare-go#1151 that change the method signatures used in the provider.

I tried to minimize the changes here, by keeping the 'generic' cloudFlareChange struct that encapsulates cloudflare.DNSRecord and is used to keep track of changes needed. Only by the time that we actually call the cloudflare library functions that we convert from the generic container to the newly specialized ones (cloudflare.UpdateDNSRecordParams, cloudflare.CreateDNSRecordParams) through a generic function.

The alternative would've have been to split the slice of type []*cloudFlareChange{} into perhaps a map that contains several change types holding the new parameter types.

Why make this change?

Since version 0.58.0, the cloudflare-go library has a PerPage attribute on cloudflare.ListDNSRecordsParams which will help reduce the number of API calls made to Cloudflare and prevent rate limit events:

https://api.cloudflare.com/#dns-records-for-a-zone-list-dns-records

Passing in the max allowed value (or parameterizing it) will be done in a follow-up PR: https://github.com/arturhoo/external-dns/compare/cloudflare-go-0.58.0...arturhoo:external-dns:cloudflare-paginated-list-requests?expand=1

Checklist

• Unit tests updated
• End user documentation updated (N/A)

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: arturhoo / name: Artur Rodrigues (15a8a9b, 3c82b0c, e2ff260)

[k8s-ci-robot]

Welcome @arturhoo!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[szuecs]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arturhoo, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [szuecs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[szuecs]

/assign @njuettner

[szuecs]

I am not yet allowed to press the test run button

[arturhoo]

@njuettner would you be able to help with the approval for running the test workflows? I suppose this PR also needs a lgtm.
Happy to make adjustments if necessary.

Once this gets merged, I'll create a PR for the changes in https://github.com/arturhoo/external-dns/compare/cloudflare-go-0.58.0...arturhoo:external-dns:cloudflare-paginated-list-requests?expand=1 - thanks

[Raffo]

@arturhoo can you fix the CI errors (linting).

[Raffo]

/lgtm