Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added traefik-proxy rules to helm chart #3325

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

ThomasK33
Copy link
Contributor

As a follow-up to #3055, as suggested by @stevehipwell.
Only merge this once #3055 is merged onto the master.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 15, 2023
@stevehipwell
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 31, 2023
@stevehipwell
Copy link
Contributor

/ok-to-test

@stevehipwell
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2023
@stevehipwell
Copy link
Contributor

/unhold

(I was testing the approve workflows action)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2023
@stevehipwell
Copy link
Contributor

/hold

Testing the approve GH Actions workflow again.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2023
@stevehipwell
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2023
@stevehipwell
Copy link
Contributor

/hold

Testing the approve GH Actions workflow again.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2023
@stevehipwell
Copy link
Contributor

/unhold

It worked!! 🥳

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2023
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasK33 thanks for your patience. Could you add a chart CHANGELOG entry under a new ## [UNRELEASED] heading at the top and following the conventions from the last entry?

@stevehipwell
Copy link
Contributor

stevehipwell commented Mar 30, 2023

@ThomasK33 I'd like to get this in the next release, would you be able to add a CHANGELOG entry and squash back to a single commit?

@ThomasK33 ignore the bit about the next release as I can see that this is waiting on #3055 but it'd still be good to have a CHANGELOG entry for the chart in the PR.

@ThomasK33
Copy link
Contributor Author

@ThomasK33 I'd like to get this in the next release, would you be able to add a CHANGELOG entry and squash back to a single commit?

Sure, I'll update it today, but there is no point in having this in the next release, as #3055 still isn't merged.

@ThomasK33
Copy link
Contributor Author

Hey @stevehipwell 👋

As #3055 was merged last week, I've updated this PR to include the additional, new apiGroup for Traefik traefik.io.

Let me know if anything else needs to be added. 😄

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2023
ThomasK33 and others added 3 commits June 22, 2023 19:33
Signed-off-by: Thomas Kosiewski <thoma471@googlemail.com>
Signed-off-by: Thomas Kosiewski <thomas.kosiewski@loft.sh>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2023
@stevehipwell
Copy link
Contributor

@njuettner could you take a look for a LGTM?

/approve
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 26, 2023
@k8s-ci-robot
Copy link
Contributor

@mloiseleur: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur, stevehipwell, ThomasK33

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Raffo
Copy link
Contributor

Raffo commented Jun 28, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 440f513 into kubernetes-sigs:master Jun 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants