Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automation to run GH actions on PRs with ok-to-test #3331

Merged

Conversation

stevehipwell
Copy link
Contributor

Description

This PR adds a GH workflow to automatically approve running GH actions for first time contributors once the ok-to-test label has been added. This should significantly reduce the pressure on the maintainers with repo ownership. I've tested the logic works correctly but I've not used it as a GH action yet.

IMPORTANT - This has no impact on any repo code so can be merged without fixing flaking jobs.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 17, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 17, 2023
@stevehipwell
Copy link
Contributor Author

CC @Raffo @njuettner

Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@szuecs
Copy link
Contributor

szuecs commented Jan 23, 2023

/approve

@szuecs
Copy link
Contributor

szuecs commented Jan 23, 2023

/assign @Raffo

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevehipwell, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2023
@Raffo
Copy link
Contributor

Raffo commented Jan 25, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8862af9 into kubernetes-sigs:master Jan 25, 2023
@stevehipwell stevehipwell deleted the add-gh-workflow-approval branch January 31, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants