Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MinEventInterval compliance with docs #3400

Merged
merged 2 commits into from
Aug 13, 2024

Commits on Aug 6, 2024

  1. Improve MinEventInterval compliance with docs

    **Description**
    
    In the command line arguments, we see `min-event-sync-interval` as
    "The minimum interval between two consecutive synchronizations triggered from kubernetes events"
    
    In the code, it actually acts a different way.
    
    It imposes a certain dealy between syncs.
    While this is compliant with the "minimum delay between 2 consecutive
    synchronizations", it has side-effects in case of large delays.
    
    In particular, when trying to fine-tune external-dns to match the
    provider rate-limits.
    
    In this case, it may be interesting to restrict the rate of reconciling
    actions happening by having a high `min-event-sync-interval`, while
    keeping a low latency for initial events.
    
    This would allow to maximise the bulk effect of high change rate while
    keeping fast enough reaction for isolated changes.
    
    **Checklist**
    
    - [X] Unit tests updated
    - [X] End user documentation updated
    > End user documentation matches the updated behaviour with more
    > accuracy
    Change-Id: Ibcea707974a095a2d5861a3974b4c79e5a15b00e
    tjamet committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    2007a49 View commit details
    Browse the repository at this point in the history
  2. Improve documentation

    tjamet committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    1b5ed44 View commit details
    Browse the repository at this point in the history