Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS VPC endpoint canonical hosted zone IDs #3433

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Add AWS VPC endpoint canonical hosted zone IDs #3433

merged 4 commits into from
Mar 8, 2023

Conversation

jwenz723
Copy link
Contributor

@jwenz723 jwenz723 commented Feb 22, 2023 •
edited

Description

Adds canonical hosted zone IDs for AWS VPC endpoint. These are commonly used with AWS PrivateLink to establish private connectivity between 2 VPCs.

I've updated the test case to automatically test all canonical hosted zone suffixes rather than requiring every suffix to be committed to both the map and the test case.

Fixes #3429

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @jwenz723!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 22, 2023
@jwenz723
Copy link
Contributor Author

/assign szuecs

@jwenz723
Copy link
Contributor Author

/unassign szuecs

@jwenz723
Copy link
Contributor Author

Sorry, for prematurely assigning the PR. I will wait to assign until after lgtm label has been added.

@jwenz723
Copy link
Contributor Author

jwenz723 commented Mar 6, 2023

/assign

@jwenz723
Copy link
Contributor Author

jwenz723 commented Mar 6, 2023

/assign szuecs

@jwenz723 jwenz723 removed their assignment Mar 6, 2023
@szuecs
Copy link
Contributor

szuecs commented Mar 8, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 8, 2023
@szuecs
Copy link
Contributor

szuecs commented Mar 8, 2023

/approve

@szuecs
Copy link
Contributor

szuecs commented Mar 8, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwenz723, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 38e7862 into kubernetes-sigs:master Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@szuecs szuecs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for AWS vpc interface endpoints
3 participants
@jwenz723 @k8s-ci-robot @szuecs