-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nodePort #2704 - publish ready endpoints #3447
fix: nodePort #2704 - publish ready endpoints #3447
Conversation
@szuecs Sorry, if you don't mind, can I request a review? Gentle ping: @njuettner, @seanmalloy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I see all new func do not need to be expoerted, so please lower case the func name.
/ok-to-test |
@szuecs done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/assign @seanmalloy |
fix: lowercase local functions chore: reuse nodes, cut logs
@seanmalloy, @szuecs gentle ping Just rebased on the current master. |
You generally don't need to rebase unless there are conflicts. Doing so requires others to re-review. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
External-dns handles nodePort differently to Service endpoints - Ignore pod status
Implement logic to check pod status and publish only ready & running pods instead of all.
Fixes #2704
Additionally:
public.ecr.aws/xflow-ltd/external-dns:0.13.5
Checklist