Use right version for exoscale/egoscale #3461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Raffo
commented
Mar 8, 2023
| github.com/exoscale/egoscale v1.19.0 | ||
| github.com/exoscale/egoscale v0.97.0 |
There was a problem hiding this comment.
This looks like a downgrade, but it is actually only sticking to the latest "valid" release, as described in #3460 .
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3460.
This PR uses the latest officially released version of exoscale/egoscale, ignoring the broken v1.19 that is still published and that was upgraded by dependabot, but that is not working due to a SHA mismatch. I am not sure what the release strategy is for exoscale/egoscale and it seems a bad idea to me to leave a release published that we are somewhat not supposed to use, but nonetheless, we will pin to
v0.97.0which is a legit release and ignore dependabot for now./cc @szuecs