Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gateway-api RBAC to helm chart clusterrole #3499

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Add gateway-api RBAC to helm chart clusterrole #3499

merged 1 commit into from
Mar 30, 2023

Conversation

michaelvl
Copy link
Contributor

Description

This PR adds gateway-API RBAC to Helm chart. This basically codifies the procedure described in docs/tutorials/gateway-api.md

Checklist

  • Unit tests updated
  • End user documentation updated

Note: both of the above are NA for this addition.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @michaelvl!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 26, 2023
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR this looks good @michaelvl but could you add a new unreleased section to the chart CHANGELOG to cover your changes so they get documented when the next release comes out.

@michaelvl
Copy link
Contributor Author

Thanks @stevehipwell - I have added a notice to the changelog.

@stevehipwell
Copy link
Contributor

@michaelvl could you squash your commits?

@michaelvl
Copy link
Contributor Author

@stevehipwell sure. Done.

@stevehipwell
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 29, 2023
@stevehipwell
Copy link
Contributor

@Raffo @seanmalloy could you take a look at this and give a LGTM?

/approved

@Raffo
Copy link
Contributor

Raffo commented Mar 30, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MichaelVL, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit f947a9e into kubernetes-sigs:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants