-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gateway-api RBAC to helm chart clusterrole #3499
Add gateway-api RBAC to helm chart clusterrole #3499
Conversation
Welcome @michaelvl! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR this looks good @michaelvl but could you add a new unreleased section to the chart CHANGELOG to cover your changes so they get documented when the next release comes out.
Thanks @stevehipwell - I have added a notice to the changelog. |
@michaelvl could you squash your commits? |
@stevehipwell sure. Done. |
/ok-to-test |
@Raffo @seanmalloy could you take a look at this and give a LGTM? /approved |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MichaelVL, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR adds gateway-API RBAC to Helm chart. This basically codifies the procedure described in
docs/tutorials/gateway-api.md
Checklist
Note: both of the above are NA for this addition.