Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected various links in ultradns.md #3524

Closed

Conversation

kundan2707
Copy link
Contributor

Description
Corrected various ultraDNS related links in https://github.com/kubernetes-sigs/external-dns/blob/master/docs/tutorials/ultradns.md

Fixes #3523

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 31, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2023
@kundan2707
Copy link
Contributor Author

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 31, 2023
@szuecs
Copy link
Contributor

szuecs commented Mar 31, 2023

@kundan2707 how do we know that this is true?
I checked that the .com page is hosted at AWS and .neustar is hosted on an IP which is owned by neustar company.
So right now I can't judge about, if the .com page is owned by neustar company or if it's a fake site by someone else. SAN entry of the .com cert shows that it has "DNS Name: *.ultradns.neustar", so likely you are right.
Do you have maybe other references?

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 4, 2023
@kundan2707
Copy link
Contributor Author

@szuecs there is no other portals for ultraDNS portal which one is publicly accessible.

@szuecs
Copy link
Contributor

szuecs commented Apr 4, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kundan2707, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@szuecs
Copy link
Contributor

szuecs commented Apr 4, 2023

@kundan2707 can you sign the EasyCLA, this blocks the PR

@kundan2707
Copy link
Contributor Author

@szuecs i signed easycla and now its showing no cncf-cla

@szuecs
Copy link
Contributor

szuecs commented Jun 30, 2023

@kundan2707 no idea. Can you please reach out to some kubernetes automation folks maybe try via slack?

@szuecs
Copy link
Contributor

szuecs commented Jul 3, 2023

/close

@k8s-ci-robot
Copy link
Contributor

@szuecs: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@szuecs
Copy link
Contributor

szuecs commented Jul 3, 2023

Since there was no response I cleanup the PR

@kundan2707
Copy link
Contributor Author

kundan2707 commented Jul 18, 2023

@szuecs created new PR as easycla things havnt got resolved in this PR.
#3794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple broken link in ultradns tutorial
3 participants