Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing gateway-httproute cluster role permission #3541

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

nicon89
Copy link
Contributor

@nicon89 nicon89 commented Apr 11, 2023

Description
Adds missing permissions (namespace) for gateway-api.

Fixes #[3537]

Checklist

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 11, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: nicon89 / name: Piotr Kowalczyk (50b5268)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 11, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @nicon89!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2023
@stevehipwell
Copy link
Contributor

@nicon89 could you sign the CLA? I'll approve the tests once you've done that.

@nicon89
Copy link
Contributor Author

nicon89 commented Apr 12, 2023

@stevehipwell I tried signing it as "individual contributor" few times - I don't get any error, but I still see it is missing CLA authorization.

@stevehipwell
Copy link
Contributor

@nicon89 have you followed the guide to amend and sign (with -s) your commit once you've signed the CLA?

@stevehipwell
Copy link
Contributor

@nicon89 it looks like your missing the sign off on you commit, you should be able to fix this by running git commit --amend --no-edit -s && git push --force-with-lease.

@nicon89
Copy link
Contributor Author

nicon89 commented Apr 13, 2023

/easycla

@stevehipwell
Copy link
Contributor

@nicon89 did you sign the CLA with the email address on the commit?

Signed-off-by: Piotr Kowalczyk <nicon@bash.org.pl>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 13, 2023
@nicon89
Copy link
Contributor Author

nicon89 commented Apr 13, 2023

@stevehipwell sorry for troubles, it should be now okay.

@stevehipwell
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 13, 2023
@szuecs
Copy link
Contributor

szuecs commented Apr 13, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nicon89, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit cf79d37 into kubernetes-sigs:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants