Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Canonical Hosted Zone IDs for ELB/NLB in eu-south-2 (Spain) AWS region #3604

Merged
merged 1 commit into from
May 16, 2023
Merged

Add Canonical Hosted Zone IDs for ELB/NLB in eu-south-2 (Spain) AWS region #3604

merged 1 commit into from
May 16, 2023

Conversation

baziliolg
Copy link
Contributor

AWS Spain (eu-south-2) region is not yet fully supported by external-dns, which results in the following warning messages from the latest-version external-dns Pod:

level=warning msg="Could not find canonical hosted zone for domain REDACTED.eu-south-2.elb.amazonaws.com. This may be because your region is not supported yet."

Annotation external-dns.alpha.kubernetes.io/aws-target-hosted-zone does nothing (or maybe it's me, as I'm not sure which k8s entity the annotation should be added to; I've tried all entitied related to external-dns as well as my Ingresses), the DNS records still are not created:

level=error msg="Failed submitting change (error: InvalidChangeBatch: [RRSet of type TXT with DNS name prometheus.dev.example.com. is not permitted because a conflicting RRSet of type CNAME with the same DNS name already exists in zone dev.example.com.]\n\tstatus code: 400, request id: REDACTED), it will be retried in a separate change batch in the next iteration"

I've tried limiting batch size to 1 or 2, but this did not resolve the issue.

As soon as I built own external-dns Docker image with known ELB Canonical Hosted Zone ID for eu-south-2 added to the code, external-dns created DNS records successfully, no warnings, no errors.

No Issue is filed for this problem yet.

Checklist

  • Unit tests updated - no need
  • End user documentation updated - no need

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 12, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: baziliolg / name: Maksym Pylypenko (65b1fd7)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 12, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @baziliolg!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 12, 2023
@johngmyers
Copy link
Contributor

Verified against https://docs.aws.amazon.com/general/latest/gr/elb.html
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2023
@johngmyers
Copy link
Contributor

/assign raffo

@szuecs
Copy link
Contributor

szuecs commented May 16, 2023

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baziliolg, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9861507 into kubernetes-sigs:master May 16, 2023
@baziliolg baziliolg deleted the baziliolg/eu-south-2 branch May 16, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants