Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ExternalDNS to go 1.20 #3673

Merged
merged 5 commits into from
Jun 12, 2023
Merged

Upgrade ExternalDNS to go 1.20 #3673

merged 5 commits into from
Jun 12, 2023

Conversation

mloiseleur
Copy link
Contributor

@mloiseleur mloiseleur commented Jun 9, 2023 •
edited

Description

This PR

Checklist

  • Build and tests are green

@dependabot @mloiseleur
build(deps): bump golang from 1.19 to 1.20
9174462 
Bumps golang from 1.19 to 1.20.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 9, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 9, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @mloiseleur!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 9, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2023
@mloiseleur mloiseleur changed the title build(deps): bump golang from 1.19 to 1.20 Upgrade ExternalDNS to go 1.20 Jun 9, 2023
szuecs
szuecs reviewed Jun 12, 2023
View reviewed changes
provider/coredns/coredns.go Outdated Show resolved Hide resolved
szuecs
szuecs reviewed Jun 12, 2023
View reviewed changes
source/fake.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2023
@szuecs
Copy link
Contributor

szuecs commented Jun 12, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 12, 2023
@szuecs
Copy link
Contributor

szuecs commented Jun 12, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@Raffo
Copy link
Contributor

Raffo commented Jun 12, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit e62d2f3 into kubernetes-sigs:master Jun 12, 2023
10 checks passed
@mloiseleur mloiseleur deleted the golang-1.20 branch June 12, 2023 15:22
@Raffo Raffo mentioned this pull request Jun 13, 2023
Closed
@mloiseleur mloiseleur mentioned this pull request Jun 16, 2023
Closed
9 tasks
@mloiseleur mloiseleur mentioned this pull request Jul 31, 2023
Merged
@mloiseleur mloiseleur mentioned this pull request Sep 8, 2023
Merged
2 tasks
@mloiseleur mloiseleur mentioned this pull request Nov 8, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szuecs szuecs szuecs left review comments

@njuettner njuettner Awaiting requested review from njuettner

Assignees

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mloiseleur @k8s-ci-robot @szuecs @Raffo