Fix bug in the civo provider to avoid infinite record creation #3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
Hi @seanmalloy @njuettner can you check this PR, Thanks in advance |
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
szuecs
reviewed
Jun 15, 2023
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
|
Sorry have not much time, but lgtm from my side. Please rebase the PR on top of origin/master, thanks /ok-to-test |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
removed
the
needs-rebase
Signed-off-by: Alejandro J. Nuñez Madrazo <alejandro@civo.com>
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alejandrojnm, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the Civo provider to avoid infinite record creation
No issue
Checklist