Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mloiseleur to reviewer group #3700

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

Raffo
Copy link
Contributor

@Raffo Raffo commented Jun 16, 2023

Description

This PR adds mloiseleur to the reviewer group.

/cc @szuecs for approval

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@k8s-ci-robot k8s-ci-robot requested a review from szuecs June 16, 2023 15:55
@k8s-ci-robot
Copy link
Contributor

@Raffo: GitHub didn't allow me to request PR reviews from the following users: for, approval.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description

This PR adds mloiseleur to the reviewer group.

/cc @szuecs for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2023
@Raffo
Copy link
Contributor Author

Raffo commented Jun 16, 2023

Ok, parking this until we can add @mloiseleur to the kubernetes-sigs org. I will spin up a PR for that too.

@Raffo
Copy link
Contributor Author

Raffo commented Jun 16, 2023

@mloiseleur can you please create an issue to request your membership to the kubernetes sigs org? You have to do this here: https://github.com/kubernetes/org/issues/new/choose . You can put me and @szuecs as sponsors.

@mloiseleur
Copy link
Contributor

@Raffo here it is: kubernetes/org#4301

@johngmyers
Copy link
Contributor

Technically, per https://github.com/kubernetes/community/blob/master/community-membership.md it is a requirement for reviewers to have been a member for at least 3 months.

@@ -13,6 +13,7 @@ reviewers:
- raffo
- seanmalloy
- szuecs
- mloiseleur
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be in alphabetical order?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no such requirement.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, when modifying a list that is already in alphabetical order I try to maintain that order.

@Raffo
Copy link
Contributor Author

Raffo commented Jun 17, 2023

@johngmyers TIL about the 3 months timeline, I wasn't aware of such requirement. We can respect it, it's no big deal, but it's mostly a limitation and not really helping the project.

@johngmyers
Copy link
Contributor

Another requirement is "Reviewed or merged at least 20 substantial PRs to the codebase." I only see 14 PRs total with a comment. Of those, I could only find one review with feedback.

I am very happy for the help and enthusiastically welcome @mloiseleur to membership, but I think reviewer is a bit premature.

@Raffo
Copy link
Contributor Author

Raffo commented Jun 18, 2023

Well, we'll park it here until the prerequisite are established then.

@mloiseleur
Copy link
Contributor

/retest

@mloiseleur
Copy link
Contributor

@johngmyers Is there still a prerequisite I should fulfill ?

@johngmyers
Copy link
Contributor

I believe you become eligible on October 19.

@johngmyers
Copy link
Contributor

/lgtm
/verify-owners

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Oct 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 95daddd into master Oct 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants