support external ips for istio

[JaehoonHyun]

Description

When externalIPs of service which is loadbalancer type created, external-dns doesn't support for istio-gateway, istio-virtualservice.

Checklist

• Unit tests updated
• End user documentation updated

[mloiseleur]

thanks @JaehoonHyun
CLA step is ok.
Now, this PR needs some (unit) tests. Do you think you can add them ?

[JaehoonHyun]

thanks @JaehoonHyun CLA step is ok. Now, this PR needs some (unit) tests. Do you think you can add them ?

oh, I got it. Thanks your rapid response. I will try it now

[k8s-ci-robot]

@mloiseleur: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JaehoonHyun, mloiseleur
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JaehoonHyun]

@mloiseleur
And then Next What do I do?

[mloiseleur]

@JaehoonHyun Reviewers and maintainers will review it when they can.

[johngmyers]

For the Service source, ExternalIPs take precedence over LoadBalancer.Ingress. Why do the Istio sources need to return both?

[johngmyers]

Would it make sense to call extractLoadBalancerTargets() instead of (incompletely) duplicating the logic?

[johngmyers]

Is it intentional that the code also includes the ExternalIPs of matching Services of type other than LoadBalancer?

[JaehoonHyun]

For the Service source, ExternalIPs take precedence over LoadBalancer.Ingress. Why do the Istio sources need to return both?

in this case, I don't consider the priority. you want to do same thing like Service

[JaehoonHyun]

Is it intentional that the code also includes the ExternalIPs of matching Services of type other than LoadBalancer?

noop. I will make same priority like Service

[johngmyers]

In #3734 we're discussing the possibility of refactoring the service source to make its endpoint extraction code consumable by sources such as Istio.

[JaehoonHyun]

In #3734 we're discussing the possibility of refactoring the service source to make its endpoint extraction code consumable by sources such as Istio.

Is it right thing? I feel that these code are target to independent logic.

[johngmyers]

@JaehoonHyun could you explain why you believe the logic should be independent?

[JaehoonHyun]

@JaehoonHyun could you explain why you believe the logic should be independent?

I have refer Service code, Istio Gateway code and Virtual service code, it is some different test code style between Service and Istio Resources.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.