-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support external ips for istio #3720
support external ips for istio #3720
Conversation
thanks @JaehoonHyun |
oh, I got it. Thanks your rapid response. I will try it now |
@mloiseleur: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JaehoonHyun, mloiseleur The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mloiseleur |
@JaehoonHyun Reviewers and maintainers will review it when they can. |
For the |
Would it make sense to call |
Is it intentional that the code also includes the |
in this case, I don't consider the priority. you want to do same thing like |
noop. I will make same priority like Service |
In #3734 we're discussing the possibility of refactoring the service source to make its endpoint extraction code consumable by sources such as Istio. |
Is it right thing? I feel that these code are target to independent logic. |
@JaehoonHyun could you explain why you believe the logic should be independent? |
I have refer Service code, Istio Gateway code and Virtual service code, it is some different test code style between Service and Istio Resources. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
When externalIPs of service which is loadbalancer type created, external-dns doesn't support for istio-gateway, istio-virtualservice.
Checklist