Add --exclude-record-types flag #3748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
needs-rebase
johngmyers
force-pushed
the
exclude-managed
branch
from
76db778 to
ebcaaab
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
needs-rebase
johngmyers
force-pushed
the
exclude-managed
branch
from
ebcaaab to
77f9457
Compare
k8s-ci-robot
removed
the
needs-rebase
johngmyers
force-pushed
the
exclude-managed
branch
3 times, most recently
from
bf3c69d to
ad8d30a
Compare
k8s-ci-robot
added
the
needs-rebase
johngmyers
force-pushed
the
exclude-managed
branch
from
ad8d30a to
c19b80b
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
the
needs-rebase
johngmyers
force-pushed
the
exclude-managed
branch
from
c19b80b to
d3fd4ed
Compare
k8s-ci-robot
removed
the
needs-rebase
johngmyers
force-pushed
the
exclude-managed
branch
from
d3fd4ed to
94713c2
Compare
|
/cc @mloiseleur |
|
Between using: |
k8s-ci-robot
added
the
lgtm
|
The issue is that as we add more record types to the default, removing a record type becomes increasingly troublesome. With the CRD, having the default be so narrow is troublesome. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an
--exclude-record-typesflag. This allows for easier removal from the default--manage-record-typesset.Checklist