-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of target annotations in gateway source #3751
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: solmonk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @solmonk! |
@@ -12,7 +12,7 @@ The following table documents which sources support which annotations: | |||
| CloudFoundry | | | | | | | | |||
| CRD | | | | | | | | |||
| F5 | | | | | Yes | | | |||
| Gateway | Yes | Yes[^1] | | | Yes | Yes | | |||
| Gateway | Yes | Yes[^1] | | Yes | Yes | Yes | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we footnote to specify which annotations are supported on the Gateway
and which on the various *Route
resources? It looks like this PR only supports target
on the *Route
resources?
}, | ||
Status: gatewayStatus("1.2.3.4"), | ||
}}, | ||
routes: []*v1beta1.HTTPRoute{{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be helpful to add test cases for the other *Route
resource types?
Per my comments in #3749, I believe the target annotation should be consumed from the |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Implemented in #3452 (except the annotation is on the |
@johngmyers: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
Supports
external-dns.alpha.kubernetes.io/target
annotation on Gateway Routes, so that the DNS record targets are configurable at Route level.Expecting this to provide more flexibility on configuring DNS for different kinds of Gateway API implementations - please refer to #3749 for details on the issue.
Fixes #3749
Checklist