Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use only tags with prefix v for version determination #3760

Merged

Conversation

cgroschupp
Copy link
Contributor

Description

grafik

git describe uses the wrong tag for the container images.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2023
@cgroschupp cgroschupp marked this pull request as ready for review July 3, 2023 07:11
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 3, 2023
@johngmyers
Copy link
Contributor

I think we should make the same change to scripts/releaser.sh. It doesn't appear to be used by Helm chart releases.

@cgroschupp
Copy link
Contributor Author

I think we should make the same change to scripts/releaser.sh. It doesn't appear to be used by Helm chart releases.

done

@johngmyers
Copy link
Contributor

/ok-to-test
/lgtm
/assign @szuecs

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 3, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2023
@szuecs
Copy link
Contributor

szuecs commented Jul 3, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgroschupp, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 92824f4 into kubernetes-sigs:master Jul 3, 2023
@cgroschupp
Copy link
Contributor Author

@johngmyers
Copy link
Contributor

johngmyers commented Jul 3, 2023

@cgroschupp I believe that is a question to ask in https://github.com/kubernetes-sigs/image-builder

@johngmyers
Copy link
Contributor

johngmyers commented Jul 3, 2023

@cgroschupp It's because of line 90 in Makefile.

@johngmyers
Copy link
Contributor

@cgroschupp
Copy link
Contributor Author

@johngmyers Can you look over there, please? kubernetes/test-infra#30006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants