-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use only tags with prefix v for version determination #3760
use only tags with prefix v for version determination #3760
Conversation
f14255b
to
63c9f61
Compare
I think we should make the same change to |
63c9f61
to
d9a433e
Compare
done |
d9a433e
to
2c6655c
Compare
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgroschupp, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@szuecs @johngmyers I need some help to understand why Prow pushes the image with the wrong tag: https://storage.googleapis.com/kubernetes-jenkins/logs/post-external-dns-push-images/1675907490161627136/artifacts/build.log |
|
|
@johngmyers Can you look over there, please? kubernetes/test-infra#30006 |
Description
git describe
uses the wrong tag for the container images.Checklist