Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the Ingress source #3806

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Document the Ingress source #3806

merged 1 commit into from
Sep 4, 2023

Conversation

johngmyers
Copy link
Contributor

Description

Adds reference documentation for the ingress source

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 22, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2023
mloiseleur
mloiseleur reviewed Jul 28, 2023
View reviewed changes
docs/sources/ingress.md Outdated Show resolved Hide resolved
mloiseleur
mloiseleur reviewed Jul 28, 2023
View reviewed changes
docs/sources/ingress.md Outdated Show resolved Hide resolved
mloiseleur
mloiseleur reviewed Jul 28, 2023
View reviewed changes
docs/sources/ingress.md Outdated Show resolved Hide resolved
mloiseleur
mloiseleur reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@mloiseleur mloiseleur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two small suggestions and I have two comments:

  1. In docs/sources/sources.md, what is the purpose of empty Status column ?
  2. The change in source/ingress.go does not look like a documentation change.

@johngmyers
Copy link
Contributor Author

The Status column was intended to report support level, but I don't think we have a good source of information for that.

I reformatted with bullet points. I don't think sub-bullet points are appropriate.

The change in source/ingress.go is a simplification refactor with no behavioral change.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@mloiseleur
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@johngmyers
Copy link
Contributor Author

@Raffo could you take a look at this? It's stalling a bunch of my documentation work.

Raffo
Raffo approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@Raffo Raffo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6a53959 into kubernetes-sigs:master Sep 4, 2023
14 checks passed
@johngmyers johngmyers deleted the doc-sources branch September 4, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raffo Raffo Raffo approved these changes

@mloiseleur mloiseleur mloiseleur approved these changes

@njuettner njuettner Awaiting requested review from njuettner

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@Raffo Raffo

@mloiseleur mloiseleur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johngmyers @mloiseleur @k8s-ci-robot @Raffo