Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove txt-encryption nonce, for prevent issues with txt records deletion #3808

Closed
wants to merge 1 commit into from

Conversation

vsychov
Copy link
Contributor

@vsychov vsychov commented Jul 23, 2023

Description
Fixes #3668

Alternative and better fix is #3735
@szuecs

… with txt records deletion

Signed-off-by: Viacheslav Sychov <viacheslav.sychov@gmail.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vsychov
Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 23, 2023
@vsychov vsychov changed the title Fix #3668: Remove txt-encryption nonce, for prevent issues with txt records deletion Remove txt-encryption nonce, for prevent issues with txt records deletion Jul 24, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 24, 2023
@johngmyers
Copy link
Contributor

I'm wary of this approach. The TXT registry is relying on being able to perfectly reconstruct an identical ownership record and the encryption nonce is breaking this. But disabling an encryption countermeasure seems risky.

Alternative approaches would be to ensure all the old TXT records are stashed away long enough for the deletion code to retrieve them or to save the nonce in a providerspecific property.

But then I think this entire encryption feature is insanity.

@mloiseleur
Copy link
Contributor

Since we will focus on #3901, I close this PR.
/close

@k8s-ci-robot
Copy link
Contributor

@mloiseleur: Closed this PR.

In response to this:

Since we will focus on #3901, I close this PR.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When enable encryption of TXT record, Deletion of the DNS record failed.
4 participants