-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: align PDNS provider by removing MatchParent #3869
fix!: align PDNS provider by removing MatchParent #3869
Conversation
This test is expected to fail and aims to show that regex domain filter is not working.
PNDS provider is the only one which uses MatchParent functionality. The MatchParent functionality breaks domain and regex domain filters. It also makes PDNS provider behave differently than other providers while having the same configuration. MatchParent can be replaced by using multiple domain filters. After discussion with maintainers we concluded that MatchParent should be removed.
Hi @matusf. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retitle fix!: align PDNS provider by removing MatchParent |
/retest |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matusf, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
PNDS provider is the only one which uses MatchParent functionality. The
MatchParent functionality breaks domain and regex domain filters. It
also makes PDNS provider behave differently than other providers while
having the same configuration. MatchParent can be replaced by using
multiple domain filters. After discussion with maintainers we concluded
that MatchParent should be removed.
The removal was discussed in #3828
Fixes #3816 #3828 #3822
Checklist