Potential fix for nonce usage issue on update record when encryption is enabled

[ajopanoor]

Description

• First part of the fix adds the deleted nonce back to labels associated with the ownership record in Serialize() method.
• Since the ownership records are always generated from base A/CNAME record, second part of the fix updates the record encryption method such that, same nonce will be used for encrypting both old and new ownership records associated with an A/CNAME record. Since contents generated for both old and new ownership record are the same, the cipher text after encryption will also be the same as same nonce value is used. This fixes the UPDATE record failures, however has an impact on the entropy, but will help avoiding major changes to the ownership record book keeping code.

Fixes #3953

Checklist

• Unit tests updated
• End user documentation updated

[linux-foundation-easycla]

• ❌ - login: @ajopanoor / name: Ajo Jose Panoor . The commit (eaa892e) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

Welcome @ajopanoor!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ajopanoor. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mloiseleur]

Hello @ajopanoor,

Thanks for this PR.
I'm wondering: is it a duplicate or an alternative of #3901 ?

[mloiseleur]

No CLA signed and no answer since a month => I close it.
Feel free to re-open it.
/close

[k8s-ci-robot]

@mloiseleur: Closed this PR.

In response to this:

No CLA sign and no answer since a month => I close it.
Feel free to re-open it.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.