Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: regression on scaleway provider in 0.14.0 #4039
fix: regression on scaleway provider in 0.14.0 #4039
Changes from 3 commits
811b425
bf3065e
fc2f5ac
d6ce656
1dc4690
e542a62
37a8010
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here you overwrite the error and it's not clear why we don't care about the error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reused the same logic from the original PR that has been reviewed but we can change this of course. I can add a log when the file can't be loaded and when the profile was not loaded too if that's okay for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes please, I added an example how to make it better. I hope it helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I keep this thread as it's the one that make most sense from the original idea.
I've added warning in logging because if someone try to use config file and the file contains error he will not be warned about that and can't understand the issue, that's why I think logs are better in the end.
If you don't like the submitted code, feel free to change it as I've don't a lot of knowledge in Go and don't want to waste your time in reviewing and make it hard. Was doing it to help a bit if I can 🙂.
Regards,