feat(helm-chart): Allow passing zone-id-filter from helm values

[egarbi]

Description

This PR allows users to pass args --zone-id-filter as a list from Helm's values.
This is particularly useful for AWS to avoid getting API Rate limits or access-denied issues with IAM.
domainFilters could be used as an alternative but it's not good enough when you have the same domain associated with different zones (ie: private and public zones)

it will help to fix this one](aws-ia/terraform-aws-eks-blueprints-addons#333)
Checklist

• Unit tests updated
• End user documentation updated

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stevehipwell for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• charts/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: egarbi / name: Enrique Garbi (738a931)

[k8s-ci-robot]

Welcome @egarbi!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @egarbi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevehipwell]

Thanks for the PR @egarbi but we currently only support setting optional args via the extraArgs chart value.

/close

[k8s-ci-robot]

@stevehipwell: Closed this PR.

In response to this:

Thanks for the PR @egarbi but we currently only support setting optional args via the extraArgs chart value.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[egarbi]

--zone-id-filter

Thanks for the PR @egarbi but we currently only support setting optional args via the extraArgs chart value.

/close

Well, that is not entirely true because domainFilters is supported and it's an optional arg too, but anyway. I will use a diff approach then, thanks

[stevehipwell]

@egarbi AFAIR domainFilters are relevant for all/most providers so are in the chart API.